refactor(state-sync): Rename module: syncing -> state_sync
#9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions 0.5.1 - 0.5.7 were yanked due to a race condition. See [changelog](/~https://github.com/crossbeam-rs/crossbeam/blob/master/crossbeam-channel/CHANGELOG.md#version-058) and [crates.io](https://crates.io/crates/crossbeam-channel/versions) and [PR with the fix](crossbeam-rs/crossbeam#972).
…manager, runtime in integration tests (#9595) We had a common pattern of creating a bunch of manual stores, epoch managers, and nightshade runtime for the test environment. This PR brings the default functionality to the test environment builder.
The point of this file is to quickly see the current parameters. Showing the nightly changes is not in this spirit IMO.
`cargo-deny advisories` complains about an old libsqlite-sys version. We depend on it through rusqlite, which is only used in the `estimator-warehouse`, a CI /&debug script. So it's not super important but still worth updating.
Breaking a large test_utils.rs file into multiple parts. Additionally shifting location of `TestEnvNightshadeSetupExt` to nearcore so that it can be used in other modules, specifically `tools/state-viewer/src/state_dump.rs`. Note that we can't have `TestEnvNightshadeSetupExt` in `chain/client/src/test_utils` as it depends on NightshadeRuntime which is a part of `nearcore` module. `nearcore` module depends on `chain` and would create a cyclic dependency.
nikurt
added a commit
that referenced
this pull request
Oct 2, 2023
Co-authored-by: Jakob Meier <mail@jakobmeier.ch> Co-authored-by: Shreyan Gupta <shreyan@near.org>
nikurt
added a commit
that referenced
this pull request
Oct 2, 2023
Co-authored-by: Jakob Meier <mail@jakobmeier.ch> Co-authored-by: Shreyan Gupta <shreyan@near.org>
nikurt
added a commit
that referenced
this pull request
Oct 2, 2023
Co-authored-by: Jakob Meier <mail@jakobmeier.ch> Co-authored-by: Shreyan Gupta <shreyan@near.org>
nikurt
added a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: Jakob Meier <mail@jakobmeier.ch> Co-authored-by: Shreyan Gupta <shreyan@near.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.